Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate screenshotting for the readme WD-11363 #776

Merged
merged 1 commit into from
May 24, 2024
Merged

Automate screenshotting for the readme WD-11363 #776

merged 1 commit into from
May 24, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented May 22, 2024 •
edited
Loading

Done

  • test to be run manually, which will create screenshots for the readme
  • update screens in the readme

Screenshots

create-instance
instance-graphical-console
instance-list
instance-terminal
operations-list
profile-list
storage-pool-list
warnings-list

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@edlerd edlerd force-pushed the automate-screenshots branch 2 times, most recently from e0a8d65 to 78444ad Compare May 22, 2024 16:50
@edlerd edlerd force-pushed the automate-screenshots branch 2 times, most recently from 4977467 to fb55a64 Compare May 23, 2024 08:29
@edlerd
feat(docs) automate screenshotting for the readme WD-11363
f3da4a5 
Signed-off-by: David Edler <david.edler@canonical.com>
mas-who
mas-who reviewed May 24, 2024
View reviewed changes
README.md
@@ -34,12 +34,12 @@ LXD-UI is a single page application written in TypeScript and React. See [Archit

| Create an instance | Instance list | Instance terminal |
|-----------------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------|
| ![0create](https://github.com/canonical/lxd-ui/assets/1155472/7f0c45a6-2ba2-4cc7-bd7c-c0ebca76d648) | ![1instance-overview](https://github.com/canonical/lxd-ui/assets/1155472/c71d2153-ea71-4ecb-ab25-fabcd6fb1e55) | ![2instance-term](https://github.com/canonical/lxd-ui/assets/1155472/c2b741e2-8806-4d4d-9a9a-f536f76a13b9) |
| ![0create](https://github.com/canonical/lxd-ui/assets/1155472/8c4f5eee-9d5a-40ca-93e1-57b1c393dbd9) | ![1instance-overview](https://github.com/canonical/lxd-ui/assets/1155472/af4a92ce-e562-43eb-945f-98b78b4bb03e) | ![2instance-term](https://github.com/canonical/lxd-ui/assets/1155472/14eaaffb-c770-4f34-936f-075ceb6be42e) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my understanding, where do we get these uuids?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the screens to the description of this PR and then used the ids that github created in our readme.

@mas-who
Copy link
Contributor

mas-who commented May 24, 2024

LGTM, thanks for automating this!

@edlerd edlerd merged commit bcad8b1 into canonical:main May 24, 2024
12 checks passed
@edlerd edlerd deleted the automate-screenshots branch May 24, 2024 07:37
github-actions bot pushed a commit that referenced this pull request May 24, 2024
workflow: remove all reports for PR #776
a57d69c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mas-who mas-who mas-who approved these changes

Assignees
No one assigned
Labels
Review: Code +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edlerd @webteam-app @mas-who