Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix readme-screenshots.spec.ts to properly skip tests in CI environment #782

Merged
merged 1 commit into from
May 27, 2024
Merged

fix: fix readme-screenshots.spec.ts to properly skip tests in CI environment #782

merged 1 commit into from
May 27, 2024

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented May 27, 2024

Done

  • update screenshot tests to use beforeEach hook for skipping in CI.

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • ensure CI passes

@mas-who
fix: fix readme-screenshots.spec.ts to properly skip tests in CI envi…
6eb68e7 
…ronment

Signed-off-by: Mason Hu <mason.hu@canonical.com>
@webteam-app
Copy link

Demo

Jenkins

demos.haus

edlerd
edlerd approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@mas-who mas-who merged commit ebae265 into canonical:main May 27, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request May 27, 2024
workflow: remove all reports for PR #782
8a857a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
Review: Code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mas-who @webteam-app @edlerd