Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WD-11661] feat: Added 2 storage e2e test to increase coverage. #791

Merged
merged 1 commit into from
Jun 6, 2024
Merged

[WD-11661] feat: Added 2 storage e2e test to increase coverage. #791

merged 1 commit into from
Jun 6, 2024

Conversation

Kxiru
Copy link
Contributor

@Kxiru Kxiru commented Jun 5, 2024

  • Storage pool with driver zfs
  • Storage volume of type block

Done

  • Added 2 new tests as mentioned above.
  • Edited createPool in storagePool.ts and createVolume in storageVolume.ts to accommodate different property types.

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • N/A

Screenshots

N/A

@Kxiru Kxiru requested review from edlerd and mas-who June 5, 2024 16:34
@Kxiru Kxiru self-assigned this Jun 5, 2024
@webteam-app
Copy link

Demo

Jenkins

demos.haus

edlerd
edlerd approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/helpers/storagePool.ts Outdated Show resolved Hide resolved
@mas-who
Copy link
Contributor

mas-who commented Jun 5, 2024

Looks good 👍 small nit, you don't need the QA label for this PR 🙂

@Kxiru
feat: Added 2 storage e2e test to increase coverage.
42f2df5 
- Storage pool with driver zfs
- Storage volume of type block

Signed-off-by: Nkeiruka <nkeiruka.whenu@canonical.com>
@Kxiru Kxiru merged commit 8216054 into canonical:main Jun 6, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 6, 2024
workflow: remove all reports for PR #791
7d3fe2a
@Kxiru Kxiru deleted the storage-e2e-tests branch June 17, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

@mas-who mas-who mas-who approved these changes

Assignees

@Kxiru Kxiru

Labels
Review: Code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kxiru @webteam-app @mas-who @edlerd