Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fixes stable 5.0 #11941

Merged
merged 12 commits into from
Jul 10, 2023
Merged

Conversation

ru-fu
Copy link
Contributor

@ru-fu ru-fu commented Jul 5, 2023

No description provided.

ru-fu and others added 11 commits July 5, 2023 14:22
Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
Fix broken links to linuxcontainers and update the GitHub links.
Also get rid of some doc scripts and files that aren't needed
anymore on RTD.

Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
Signed-off-by: David Edler <david.edler@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Jul 5, 2023
Copy link
Contributor

@roosterfish roosterfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@tomponline
Copy link
Member

I think we'll need to have a PR that renames the go modules first so we can get a clear build run on this PR.

Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets hold off until we've done a PR to rename the go modules so that the Go build tests pass.

@ru-fu
Copy link
Contributor Author

ru-fu commented Jul 5, 2023

OK. We'll have the wrong header & logo in the older docs though until the PR goes in.

@tomponline
Copy link
Member

OK. We'll have the wrong header & logo in the older docs though until the PR goes in.

I will endeavor to get to it ASAP.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
@tomponline
Copy link
Member

Lets merge this for now as ive not had time to sort out the 5.0 Go changes yet.

@tomponline tomponline merged commit c6daf73 into canonical:stable-5.0 Jul 10, 2023
14 of 16 checks passed
@ru-fu ru-fu deleted the doc-fixes-stable-5.0 branch July 10, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants