lxc/cluster_group: Added lxc cluster group add #11980
Conversation
There was a problem hiding this comment.
Please can you add a test in test_clustering_groups and update https://linuxcontainers.org/lxd/docs/latest/howto/cluster_groups/ (https://github.com/canonical/lxd/blob/main/doc/howto/cluster_groups.md) with how to use the command. Thanks!
Hi @tomponline for some reason I am unable to find the |
Hi @tomponline Please review the changes for tests and let me know if anything has to change, I have also updated the document. Thanks |
There was a problem hiding this comment.
Tests are failing:
+ eval timeout --foreground 120 /home/runner/go/bin/lxc "cluster" "group" "delete" "cluster:newgroup" --verbose
+ timeout --foreground 120 /home/runner/go/bin/lxc cluster group delete cluster:newgroup --verbose
Error: Only empty cluster groups can be removed
@tomponline so basically what I am thinking is I need to remove the member before deleting the cluster group?
|
Yes, before removing the cluster group itself, you need to first remove all cluster group members. |
|
This needs a rebase too now. |
|
Please can you rebase |
taltrums
force-pushed
the
lxc-cluster-group-add
branch
from
f82ed80
to
c30175d
Compare
taltrums
force-pushed
the
lxc-cluster-group-add
branch
from
c30175d
to
5e31184
Compare
Signed-off-by: taltrums <mohmmad.talha@outlook.com>
Signed-off-by: taltrums <mohmmad.talha@outlook.com> doc: Fix lxc cluster group add command Signed-off-by: taltrums <mohmmad.talha@outlook.com>
Signed-off-by: taltrums <mohmmad.talha@outlook.com> test: Fix test for lxc cluster group add Signed-off-by: taltrums <mohmmad.talha@outlook.com>
Signed-off-by: taltrums <mohmmad.talha@outlook.com>
taltrums
force-pushed
the
lxc-cluster-group-add
branch
from
5e31184
to
868a4ce
Compare
|
Hi @tomponline, I made the changes as requested, let me know if anything needs change any further. Thanks |
Fixes #11726
Hi @monstermunchkin , Created a clean PR for LXC cluster group add. Kindly have a look.
Thanks