Move GetStoragePoolVolume to ClusterTx #12039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
reviewed
Jul 18, 2023
tomponline
reviewed
Jul 18, 2023
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
monstermunchkin
force-pushed
the
misc/database
branch
from
d68b896
to
e754ee3
Compare
|
Could you include ab40e12 in this PR too? |
There correct column name is `storage_volumes.type`. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
|
@tomponline this should allow for a single transaction when deleting expired storage volume backups. |
|
Dead code check failed |
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Fixed. |
tomponline
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.