Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate LTS version in lxc version #12785

Merged
merged 8 commits into from Jan 30, 2024
Merged

Indicate LTS version in lxc version #12785

merged 8 commits into from Jan 30, 2024

Conversation

MusicDin
Copy link
Member

Indicates LTS version when running lxc version.

Fixes #12768

@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Jan 30, 2024
@tomponline
Copy link
Member

commits need to be signed off please

tomponline
tomponline reviewed Jan 30, 2024
View reviewed changes
shared/version/flex.go Outdated Show resolved Hide resolved
@MusicDin MusicDin closed this Jan 30, 2024
@MusicDin MusicDin reopened this Jan 30, 2024
@MusicDin
Copy link
Member Author

Accidentally closed the PR..

Example outputs (when LTS is enabled):

$ lxc query /1.0 | jq '{lts: .environment.server_lts, ver: .environment.server_version}'
{
  "lts": true,
  "ver": "5.20"
}

$ lxc version
Client version: 5.20 LTS
Server version: 5.20 LTS

$ lxc --version
5.20 LTS

$ lxd version
5.20 LTS

$ lxd --version
5.20 LTS

tomponline
tomponline reviewed Jan 30, 2024
View reviewed changes
doc/api-extensions.md Outdated Show resolved Hide resolved
@MusicDin
api: Add api extension server_version_lts
841c023 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
shared/version: Add boolean indicating whether this is an LTS release
121cd7e 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
shared/api/server: Add server lts indication in ServerEnvironment
d7f51b5 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
lxd/api_1.0: Indicate lts version on server
a69a0ea 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
lxc/version: Indicate LTS version of the client and/or server
9b8986d 
Signed-off-by: Din Music <din.music@canonical.com>
tomponline
tomponline reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lxd/main_version: Indicate lts version when running 5.20 commit message doesn't make sense, 5.20 isnt an LTS version?

@MusicDin
lxd/main_version: Indicate lts version of the server
eaaf5bb 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
doc: Update rest definition
5700f3e 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
i18n: Update translations
ac92ecc 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
Copy link
Member Author

lxd/main_version: Indicate lts version when running 5.20 commit message doesn't make sense, 5.20 isnt an LTS version?

Oops, I don't know how/why this got here. Fixed

@tomponline tomponline merged commit 4c08b80 into canonical:main Jan 30, 2024
25 checks passed
@MusicDin MusicDin deleted the feat/lts-flag branch January 30, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to indicate LTS in lxc version and lxc --version commands
2 participants
@MusicDin @tomponline