Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qemu: Revert linter fix #12929

Merged
merged 1 commit into from Feb 21, 2024
Merged

Qemu: Revert linter fix #12929

merged 1 commit into from Feb 21, 2024

Conversation

roosterfish
Copy link
Contributor

This was merged yesterday in 3dec353 (as part of #12754). This PR reverts the linter fix to it's old state.

When trying to start a VM, it fails with the following error:

root@julian01:~# lxc launch ubuntu:jammy v1 --vm -s pf
Creating v1
Starting v1                                 
Error: Failed to setup virtiofsd for config drive: %!w(<nil>)
Try `lxc info --show-log local:v1` for more info

@roosterfish
lxd/instance/drivers/qemu: Revert linter fix
fa3754e 
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
tomponline
tomponline approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grumbles about another bug being introduced with a linter suggested fix

@tomponline tomponline merged commit 9d1fc22 into canonical:main Feb 21, 2024
26 checks passed
@roosterfish roosterfish deleted the fix_virtiofsd_start branch February 21, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roosterfish @tomponline