lxd: Fix incorrect network device attach warnings #12939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GetNetworkWithInterface Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
|
Any idea from where the pipeline failures are coming from? I checked |
We know microceph is broken ATM and there seems to be an issue with go tip that started last night. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #12754 introduced a commit 011affc which incorrectly started logging warnings if
networkAutoAttachwasn't able to find a matching network for the network device.This is incorrect because the majority (possibly all) of new network devices that appear on a system won't be candidates for auto attach. In fact only if a bridge network specifies
bridge.external_interfacewill this be potentially relevant.So this was causing lots of log noise unnecessarily.
However the old implementation also didn't differentiate between a "not found" DB error and a problem performing the query (which we should log about) so this PR fixes those issues.