github: Restore testing latest stable version of go rather than go tip #13052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing with go tip IMHO offers little benefit as we get the odd failure that later resolves itself which causes distractions. And if a stable release introduces changes that cause our tests to fail we will have time to fix them before we switch the snap to build with the later version as we now pin the snap to build with a specific Go version for reproduciblity. So instead lets do a basic standalone and cluster test with the latest stable version. At the moment this will cause some duplication of tests as we are explicitly testing with go 1.22, which is also the latest stable. But this will not be the case when go 1.23 comes out. This also has the benefit of of not needing to have a conditional on push as we should take a breakage on the latest stable release more seriously and stop the edge builds. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
MusicDin
approved these changes
Mar 6, 2024
tomponline
added a commit
to tomponline/lxd
that referenced
this pull request
Mar 28, 2024
Also do basic system tests with minimum supported Go version 1.19 and latest stable to catch compile issues. Brings into sync with canonical#13052 Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with go tip IMHO offers little benefit as we get the odd failure that later resolves itself
which causes distractions. And if a stable release introduces changes that cause our tests to fail
we will have time to fix them before we switch the snap to build with the later version as we now
pin the snap to build with a specific Go version for reproduciblity.
So instead lets do a basic standalone and cluster test with the latest stable version.
At the moment this will cause some duplication of tests as we are explicitly testing with go 1.22,
which is also the latest stable. But this will not be the case when go 1.23 comes out.
This also has the benefit of of not needing to have a conditional on push as we should take a
breakage on the latest stable release more seriously and stop the edge builds.
Fixes edge build introduced by #13042