Storage: Fix hang when BTRFS receive fails in RefreshVolume #13095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
changed the title
tomponline
changed the title
roosterfish
reviewed
Mar 11, 2024
tomponline
force-pushed
the
tp-btrfs
branch
2 times, most recently
from
789a468
to
d708823
Compare
roosterfish
requested changes
Mar 11, 2024
roosterfish
previously approved these changes
Mar 11, 2024
…lumeFromCopy Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…together in CreateVolumeFromCopy Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
… in CreateVolumeFromCopy As sender has by definition already ended. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…reateVolumeFromCopy Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
… fails in RefreshVolume Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
… RefreshVolume Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…FS driver For consistency. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as approach in ZFS driver's
CreateVolumeFromCopyfunction:https://github.com/canonical/lxd/blob/main/lxd/storage/drivers/driver_zfs_volumes.go#L723-L765
Related to #13085