Network: Only stop OVN device if network is populated #13114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a panic caused when stopping a device with an invalid config. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
tomponline
reviewed
Mar 12, 2024
| if err != nil { | ||
| // Don't fail here as we still want the postStop hook to run to clean up the local veth pair. | ||
| d.logger.Error("Failed to remove OVN device port", logger.Ctx{"err": err}) | ||
| } |
There was a problem hiding this comment.
Does returning an error cause the evacuation to fail, because I think we should return an error if d.network is nil as something is clear very wrong in such situations.
There was a problem hiding this comment.
If we return an error it gets logged but the evacuation will continue on.
tomponline
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a panic caused when stopping a device with an invalid config.
This doesn't yet fully resolve all the issues in #13082 but allows running the evacuation.