Auth: Don't build authorization drivers into the lxd-agent #13129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
This only builds the parts of the auth package that are referenced by the state.State struct used by the lxd-agent when building the lxd-agent. This significantly reduces the size of the lxd-agent. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
simondeziel
approved these changes
Mar 13, 2024
markylaing
reviewed
Mar 13, 2024
| // clients. It cannot be initialised until after the cluster database is operational. | ||
| DriverEmbeddedOpenFGA string = "embedded-openfga" | ||
| ) | ||
| var authorizers = map[string]func() authorizer{} |
There was a problem hiding this comment.
There is still an OpenFGA dependency in this file which we might be able to remove. We could potentially just move the interfaces into a separate file interfaces.go and keep the rest of the package as is?
There was a problem hiding this comment.
Yep we can do more for sure (and should) to isolate this.
Having to use the build directives is a bit hacky for my liking. But will suffice for now.
There was a problem hiding this comment.
i think we should perhaps have a separate agent State struct rather than sharing the one with the LXD server.
There was a problem hiding this comment.
Yeah that would be better. The agent doesn't need most of it.
markylaing
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only builds the parts of the auth package that are referenced by the state.State struct
used by the lxd-agent when building the lxd-agent.
This significantly reduces the size of the lxd-agent.