Move IPRanges parsing
#13213
Merged
Move IPRanges parsing
#13213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MggMuggins
force-pushed
the
move-iprange-parsing
branch
from
0ce082a
to
3c188e5
Compare
See canonical/microcloud#210; this is essentially a constructor so it would be handy to be able to use it in microcloud. Also moves/renames `IPRangeOverlap` to a method `Overlaps`. Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
See canonical/microcloud#210 Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
MggMuggins
force-pushed
the
move-iprange-parsing
branch
from
3c188e5
to
847a611
Compare
tomponline
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Max' comment in microcloud; this is essentially a constructor so it would be handy to have access to it everywhere that
IPRangesis accessible.