Backports (stable-5.0) #13215
Merged
Backports (stable-5.0) #13215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orage is enabled for an instance Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
This is a false positive. Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
This allows passing down VolumeCopy structs and Volume structs for snapshots into the storage driver. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
This must have been missed when we made improvements to OIDC security recently. Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Non-native binaries cannot be strip'ed: $ strip -s bin/lxc.* bin/lxd-migrate.* strip: Unable to recognise the format of the input file `bin/lxc.aarch64' strip: Unable to recognise the format of the input file `bin/lxd-migrate.aarch64' Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Call the respective storage driver functions with VolumeCopy instead of Volume. This allows passing down snapshot related information into the storage driver. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…GetNetworkWithInterface Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…ettings Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
…Backup Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
… error in NewDeviceType Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
… DB records have been generated in CreateInstanceFromBackup This ensures any device modifications are applied to the on-disk backup.yaml file. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…d/db` to `lxd/instance/instancetype` package Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com> Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…andInstanceDevices And switches to one in instance/instancetype package. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…orkServerErrorLogWriter_shouldDiscard Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…m volumes This fixes a situation in which the list of target volume snaphots gets appended with the right snapshot but wrong parent volume (source instead of target volume). Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
… import Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
To keep in sync with main branch. Also adds devices support to CreateInstanceFromBackup. Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
MusicDin
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have backported the structural changes related to storage volume volatile.uuid and then removed the actual volatile.uuid implementation parts as we dont want to add that in LXD 5.0.x.
The aim is to keep the storage subsystem mostly in sync with main so as to aid backporting storage fixes.