Check lxd-agent imports

[simondeziel]

No description provided.

[simondeziel]

@tomponline is it enough to check ./lxd-agent alone here?

[tomponline]

This seems to only track the packages explicitly imported, and not any additional chained dependencies (which was the problem we saw before).

It looks like we can do go list -f '{{ join .Deps "\n" }}' ./lxd-agent to get the full list.

And I wonder if we shouldn't also be doing that for ./client and ./lxc separately (rather than combined as it is now). Then we wouldn't need to also check ./lxc/config as well.

[simondeziel]

Good idea. Would you like me to put them all in a single script each comparing against a godeps.list file? Or you'd prefer 3 scripts (client, lxc & lxd-agent)?

In any case, I'm not sure what to do of ./shared/api if you want me to rework client-imports.sh.

[tomponline]

I don't mind how many scripts - but I think we should have a godeps.list file for each (client, lxc, lxd-agent and shared/api).

[simondeziel]

@tomponline in the lxd-agent-godeps.list files, there are many thing that feel unwanted to my untrained eye like:

github.com/beorn7/perks/quantile
github.com/canonical/go-dqlite
github.com/canonical/lxd/lxd/bgp
github.com/canonical/lxd/lxd/cgroup
github.com/canonical/lxd/lxd/cluster/config
github.com/canonical/lxd/lxd/db
github.com/canonical/lxd/lxd/dns
github.com/canonical/lxd/lxd/endpoints
github.com/canonical/lxd/lxd/firewall
github.com/canonical/lxd/lxd/idmap
github.com/canonical/lxd/lxd/instance/instancetype
github.com/canonical/lxd/lxd/maas
github.com/canonical/lxd/lxd/scriptlet/load
github.com/canonical/lxd/lxd/ucred
github.com/cenkalti/backoff/v4
github.com/juju/*
github.com/mattn/go-sqlite3
github.com/miekg/dns
github.com/openfga/*
github.com/osrg/gobgp/v3/pkg/packet/bgp
github.com/osrg/gobgp/v3/pkg/zebra
github.com/Rican7/retry/*
github.com/vishvananda/netns
github.com/robfig/cron/v3
github.com/zitadel/oidc/*
golang.org/x/crypto/blowfish                    # is that due to having sftp capability?
golang.org/x/oauth2/*

Aside from this partial and inaccurate list, I noticed the following oddities:

github.com/juju/mgo/v2/bson
github.com/juju/mgo/v2/internal/json
...
gopkg.in/mgo.v2/bson
gopkg.in/mgo.v2/internal/json
...
gopkg.in/yaml.v2
gopkg.in/yaml.v3

So 2 duplicated mgo/v2 modules and 2 versions of yaml.

[tomponline]

@simondeziel im sure there are lots of improvements that can be made - please can you open an issue for that. Some will not be possible to fix because of indirect dependencies though.

[tomponline]

@simondeziel please can we use the same .Deps list for client, shared/api and lxc too.