Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VM: Use auto-converge for all live migrations (from Incus) #13246

Merged
merged 2 commits into from
Apr 2, 2024
Merged

VM: Use auto-converge for all live migrations (from Incus) #13246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acd3e8d
incusd/instance/qemu: Set auto-converge on all migrations
stgraber Mar 27, 2024
511e013
incusd/device/disk: Remove bad comment
stgraber Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion lxd/device/disk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ func (d *disk) CanHotPlug() bool {
return true
}

// validateConfig checks the supplied config for correctness.
// isRequired indicates whether the supplied device config requires this device to start OK.
func (d *disk) isRequired(devConfig deviceConfig.Device) bool {
// Defaults to required.
Expand Down
11 changes: 11 additions & 0 deletions lxd/instance/drivers/driver_qemu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6845,6 +6845,17 @@ func (d *qemu) migrateSendLive(pool storagePools.Pool, clusterMoveSourceName str
defer revert.Fail() // Run the revert fail before the earlier defers.

d.logger.Debug("Setup temporary migration storage snapshot")
} else {
// Still set some options for shared storage.
capabilities := map[string]bool{
// Automatically throttle down the guest to speed up convergence of RAM migration.
"auto-converge": true,
}

err = monitor.MigrateSetCapabilities(capabilities)
if err != nil {
return fmt.Errorf("Failed setting migration capabilities: %w", err)
}
}

// Perform storage transfer while instance is still running.
Expand Down