Storage: Fix refresh of zfs backed VM volumes (from Incus) #13305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ZFS logic has most of its functions call themselves with the filesystem datset after processing the block volume for virtual machines. This is usually correct, but in the case of receiving a refresh stream, we specifically want to handle the snapshot rollback separately for both volumes. Signed-off-by: Stéphane Graber <stgraber@stgraber.org> (cherry picked from commit 2fc95eb5ef355ad507d4369b355b687713f920f9) Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com> License: Apache-2.0
tomponline
changed the title
|
@roosterfish thanks! Did you confirm this is an issue and that this fixes it in your own tests? |
Yes it also affects us and is resolved by the fix. I'll push an addition to the lxd-ci tests next. |
Excellent work thanks! |
tomponline
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From lxc/incus#517.
Fixes #13304.
The ZFS logic has most of its functions call themselves with the filesystem datset after processing the block volume for virtual machines.
This is usually correct, but in the case of receiving a refresh stream, we specifically want to handle the snapshot rollback separately for both volumes.
(cherry picked from commit 2fc95eb5ef355ad507d4369b355b687713f920f9)
License: Apache-2.0