Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Ubuntu 22.04 by 24.04 #13391

Merged
merged 20 commits into from
Apr 29, 2024
Merged

Replace Ubuntu 22.04 by 24.04 #13391

merged 20 commits into from
Apr 29, 2024

Conversation

simondeziel
Copy link
Member

To be merged after #13390

@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Apr 26, 2024
@simondeziel simondeziel marked this pull request as ready for review April 28, 2024 19:24
tomponline
tomponline previously approved these changes Apr 29, 2024
@simondeziel simondeziel dismissed tomponline’s stale review April 29, 2024 06:59

The merge-base changed after approval.

tomponline
tomponline previously approved these changes Apr 29, 2024
@tomponline tomponline dismissed their stale review April 29, 2024 07:00

The merge-base changed after approval.

@tomponline
Copy link
Member

@simondeziel something weird going on with this PR - i keep approving it and it keeps showing me dismissing stale review.

tomponline
tomponline previously approved these changes Apr 29, 2024
@simondeziel simondeziel dismissed tomponline’s stale review April 29, 2024 09:05

The merge-base changed after approval.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Copy link

Heads up @ru-fu - the "Documentation" label was applied to this issue.

@simondeziel
Copy link
Member Author

simondeziel commented Apr 29, 2024

@tomponline it complained like this:

The merge-base changed after approval.

I just rebased and forced pushed, let see if that fixes it?

@tomponline tomponline merged commit a0c0ea1 into canonical:main Apr 29, 2024
29 checks passed
@simondeziel simondeziel deleted the 24.04 branch April 29, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants