Instance: Allow devpts in AppArmor profile for unprivileged containers #13661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In core24 AppArmor includes security fixes and our ruleset, although the source code remains unchanged become stricter. devpts was always available for unprivileged containers because of AppArmor bugs like [1]. Let's now allow it explicitly. [1] https://bugs.launchpad.net/apparmor/+bug/1597017 Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
|
This should fix OVN tests failures on latest/edge snap: |
tomponline
changed the title
|
@mihalicyn is this safe to backport to 5.21, and 5.0 series btw? Or does it need a specific version of the apparmor parser? |
it's absolutely safe to backport to any series, because for older AppArmor versions it does nothing (devpts is allowed for old versions implicitly). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In core24 AppArmor includes security fixes and our ruleset, although the source code remains unchanged become stricter.
devpts was always available for unprivileged containers because of AppArmor bugs like [1]. Let's now allow it explicitly.
[1] https://bugs.launchpad.net/apparmor/+bug/1597017