Add loongarch64 (from Incus) #13696
Merged
Add loongarch64 (from Incus) #13696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up @ru-fu - the "Documentation" label was applied to this issue. |
|
Pretty sure that LoongArch needs to be added to |
Signed-off-by: zhaixiaojuan <zhaixiaojuan@loongson.cn> (cherry picked from commit 387f397a2537adfab3db260a70fe9b600a13c165) Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com> License: Apache-2.0
Signed-off-by: zhaixiaojuan <zhaixiaojuan@loongson.cn> (cherry picked from commit ed32f61d9dd659966b175ad65da844bf492d28bd) Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com> License: Apache-2.0
From zhaixiaojuan <zhaixiaojuan@loongson.cn> Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
simondeziel
approved these changes
Jul 2, 2024
|
Looks good to me. At the same time, it worth mentioning that saying that loongarch64 is a supported architecture is overestimation, just because we don't have any ways to actually check that it works. But this change is safe and as author of it works for Loongson, I hope it was tested internally on a real hardware. |
mihalicyn
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #13691 and lxc/incus#370