Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of image requirements metadata #9827

Merged

Conversation

cavcrosby
Copy link
Contributor

@stgraber per our discussion. My implementations stick mostly to what you suggested but there are some subtle differences. I think documentation is at a good start.

Closes #9408

@lxc-jenkins
Copy link

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

@github-actions github-actions bot added the Documentation Documentation needs updating label Jan 21, 2022
@lxc-jenkins
Copy link

Documentation preview available at: https://linuxcontainers.org/lxd/docs/pr.9827/

@stgraber
Copy link
Contributor

Looks good, just a few tiny tweaks.

I think we should also add an API extension for this. For that, add an extra commit titled api: image_restrictions and have that contain an addition to both:

  • doc/api-extensions.md
  • shared/version/api.go

@github-actions github-actions bot added the API Changes to the REST API label Jan 22, 2022
@stgraber
Copy link
Contributor

Thanks!

I'll do a quick review again, then will rebase to fix that conflict and merge your fixes into their respective commits.
Then just wait for Jenkins to give the all good and this can get merged!

Signed-off-by: Conner Crosby <conner@cavcrosby.tech>
Signed-off-by: Conner Crosby <conner@cavcrosby.tech>
Signed-off-by: Conner Crosby <conner@cavcrosby.tech>
@stgraber stgraber force-pushed the features/image-requirements-metadata branch 2 times, most recently from 3406942 to b4a89d6 Compare January 23, 2022 01:35
@stgraber
Copy link
Contributor

jenkins: test this please

stgraber and others added 3 commits January 22, 2022 21:13
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Signed-off-by: Conner Crosby <conner@cavcrosby.tech>
Signed-off-by: Conner Crosby <conner@cavcrosby.tech>
@stgraber stgraber force-pushed the features/image-requirements-metadata branch from b4a89d6 to 5fdf41f Compare January 23, 2022 02:14
@stgraber
Copy link
Contributor

jenkins: test this please

@stgraber stgraber merged commit 16577a7 into canonical:master Jan 23, 2022
@stgraber
Copy link
Contributor

Thanks!

@lxc-jenkins
Copy link

Testsuite passed

@cavcrosby cavcrosby deleted the features/image-requirements-metadata branch January 23, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add image requirements metadata
4 participants