-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of image requirements metadata #9827
Addition of image requirements metadata #9827
Conversation
This pull request didn't trigger Jenkins as its author isn't in the whitelist. An organization member must perform one of the following:
Those commands are simple Github comments of the format: "jenkins: COMMAND" |
Documentation preview available at: https://linuxcontainers.org/lxd/docs/pr.9827/ |
Looks good, just a few tiny tweaks. I think we should also add an API extension for this. For that, add an extra commit titled
|
Thanks! I'll do a quick review again, then will rebase to fix that conflict and merge your fixes into their respective commits. |
Signed-off-by: Conner Crosby <conner@cavcrosby.tech>
Signed-off-by: Conner Crosby <conner@cavcrosby.tech>
Signed-off-by: Conner Crosby <conner@cavcrosby.tech>
3406942
to
b4a89d6
Compare
jenkins: test this please |
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Signed-off-by: Conner Crosby <conner@cavcrosby.tech>
Signed-off-by: Conner Crosby <conner@cavcrosby.tech>
b4a89d6
to
5fdf41f
Compare
jenkins: test this please |
Thanks! |
Testsuite passed |
@stgraber per our discussion. My implementations stick mostly to what you suggested but there are some subtle differences. I think documentation is at a good start.
Closes #9408