Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic title to notification content #4516

Open
petermakowski opened this issue Oct 21, 2022 · 0 comments
Open

Add semantic title to notification content #4516

petermakowski opened this issue Oct 21, 2022 · 0 comments

Comments

@petermakowski
Copy link
Collaborator

to add proper semantics to notification so that you can query their content by title (something to solve in vanilla/react-components).

This will make for better accessibility and our components easier to test. Currently we have to resort to workarounds like the one below, partial text matching, or test id.

      screen.getByText((content, element) => {
        return (
          content !== "" &&
          element?.textContent?.includes(
            "Configure 1 other controller with Vault to complete this operation."
          )
        );
      })

Originally posted by @petermakowski in #4503 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant