Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vault): Add incomplete setup warning to machine list #4503

Merged
merged 5 commits into from
Oct 21, 2022

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Oct 19, 2022

Done

  • Add warning message to machine list if not all region controllers are configured with Vault
  • Add warning message to machine list if region controllers are configured with Vault but secrets are not migrated

QA

MAAS deployment

To run this branch you will need access to one of the following MAAS deployments:

Running the branch

You can run this branch by:

QA steps

  • Go to /machines
  • Ensure no Vault warnings are displayed

Fixes

Fixes https://github.com/canonical/app-tribe/issues/1407

Screenshots

Not all controllers configured

image

Secrets not migrated

image

@webteam-app
Copy link

Demo starting at https://maas-ui-4503.demos.haus

@ndv99 ndv99 marked this pull request as ready for review October 19, 2022 14:20
Copy link
Collaborator

@petermakowski petermakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate small size of the PRs, makes them much easier to review!

src/app/machines/views/MachineList/MachineList.tsx Outdated Show resolved Hide resolved
src/app/machines/views/MachineList/MachineList.tsx Outdated Show resolved Hide resolved
src/app/machines/views/MachineList/MachineList.tsx Outdated Show resolved Hide resolved
src/app/machines/views/MachineList/MachineList.tsx Outdated Show resolved Hide resolved
@petermakowski
Copy link
Collaborator

@ndv99 QA+1 Integrate with Vault is labeled as a region correctly playing nicely with VoiceOver.

Kapture 2022-10-21 at 13 11 04

@ndv99
Copy link
Contributor Author

ndv99 commented Oct 21, 2022

@ndv99 QA+1 Integrate with Vault is labeled as a region correctly playing nicely with VoiceOver.

Awesome, cheers!

@ndv99 ndv99 merged commit 886d8ad into canonical:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants