Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete dhcp #179

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Delete dhcp #179

merged 2 commits into from
Sep 5, 2019

Conversation

huwshimi
Copy link
Contributor

@huwshimi huwshimi commented Sep 5, 2019

Done:

QA:

  • Open the dhcp list.
  • Click delete and confirm.
  • The snippet should be removed from the list and a message should appear.

squidsoup
squidsoup approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@squidsoup squidsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly, thanks @huwshimi

ui/src/app/settings/views/Dhcp/DhcpList/DhcpList.js
useEffect(() => {
if (saved && deletingName) {
dispatch(
messages.add(`${deletingName} removed successfully.`, "information")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably make the message types a const somewhere. No need to do that here though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I've added: #181

@huwshimi huwshimi mentioned this pull request Sep 5, 2019
Closed
@huwshimi huwshimi merged commit 8945aa8 into canonical:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squidsoup squidsoup squidsoup approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add delete dhcp snippet confirmation
2 participants
@huwshimi @squidsoup