Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts table #183

Merged
merged 6 commits into from
Sep 10, 2019
Merged

Add scripts table #183

merged 6 commits into from
Sep 10, 2019

Conversation

squidsoup
Copy link
Contributor

Done

  • Display commissioning and testing scripts in tables.
  • Display script source on expand.

QA

  • Ensure you have some testing scripts (you may need to upload some junk via old maas settings).
  • Visit /scripts/testing and /scripts/commissioning
  • Ensure sorting works, ensure searching works
  • Click script name, you should see the script source in a code block.

@squidsoup
Copy link
Contributor Author

@lilyvidenova unfortunately there is no "author" in the script object, so I've dropped that column for now. Shall I file a MAAS bug requesting that the API is updated?

@lyubomir-popov
Copy link
Contributor

lyubomir-popov commented Sep 6, 2019

@squidsoup Are there any steps between uploading in the old maas and being able to see them in the new one?

Atm, I have:
old maas:
image
new maas:
image

@squidsoup
Copy link
Contributor Author

squidsoup commented Sep 8, 2019

@lyubomir-popov yes, you need to visit another page and return to commissioning scripts, as this uses the http API not websockets (there are no realtime updates like other parts of the app).

@squidsoup squidsoup mentioned this pull request Sep 8, 2019
@squidsoup
Copy link
Contributor Author

@lyubomir-popov @lilyvidenova can you check that you have:

REACT_APP_BASE_URL="http://<your-maas-ip>:5240/

in your .env.development.local please

@lyubomir-popov
Copy link
Contributor

@squidsoup that fixed it, thanks!

@lyubomir-popov
Copy link
Contributor

Design looks good, just one comment if possible -
Ideally this focus state should be on the chevron button even if the whole area acts as a click target.
image

@lyubomir-popov
Copy link
Contributor

lyubomir-popov commented Sep 9, 2019

One more, for a future enhancement: Once you have opened a script, it's a long scroll back to the top of the table / row you expanded. Would be nice if we had a close mechanism at the bottom of an expanded row:

image

@squidsoup
Copy link
Contributor Author

One more, for a future enhancement: Once you have opened a script, it's a long scroll back to the top of the table / row you expanded. Would be nice if we had a close mechanism at the bottom of an expanded row:

Good suggestion, thanks @lyubomir-popov - have added a card #189

@squidsoup
Copy link
Contributor Author

Design looks good, just one comment if possible -
Ideally this focus state should be on the chevron button even if the whole area acts as a click target.
image

@lyubomir-popov I've created an issue for consolidating the button toggles in both DhcpList and ScriptsList here into a component here #190

Perhaps we could address the focus state at the same time there. I've added a question for you on the issue.

@squidsoup squidsoup merged commit a7d2a56 into canonical:master Sep 10, 2019
@squidsoup squidsoup deleted the scripts-table branch September 10, 2019 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants