Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): allow either LXD or libvirt when deploying machine as VM host #2485

Merged
merged 1 commit into from Apr 12, 2021

Conversation

Caleb-Ellis
Copy link
Contributor

Done

  • Added radio buttons to the deploy form to allow either LXD or libvirt VM hosts

QA

MAAS deployment

To run this branch you will need access to one of the following MAAS deployments:

Running the branch

You can run this branch by:

QA steps

  • Open the network tab in the browser console check that the websocket connection can be found
  • Open the Deploy form for a machine and submit the form without checking the "Deploy KVM" checkbox
  • Check that the websocket request does not include either install_kvm or register_vmhost
  • Cancel deploying and open again, this time checking the "Deploy KVM" checkbox and the "LXD" radio button before submitting
  • Check that the websocket request includes register_vmhost but not install_kvm
  • Cancel deploying and open again, this time checking "libvirt" before submitting
  • Check that the websocket request includes install_kvm but not register_vmhost

Fixes

Fixes #2469

Screenshot

Screenshot_2021-04-12 Machines bolla MAAS

Copy link
Contributor

@huwshimi huwshimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of questions about the tests.

@Caleb-Ellis Caleb-Ellis merged commit d5f416a into canonical:master Apr 12, 2021
@Caleb-Ellis Caleb-Ellis deleted the deploy-lxd-vm-host branch April 12, 2021 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy KVM hosts with LXD by default
2 participants