Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore websocket connection on error lp#1930001 #5133

Merged
merged 1 commit into from Sep 4, 2023
Merged

fix: restore websocket connection on error lp#1930001 #5133

merged 1 commit into from Sep 4, 2023

Conversation

petermakowski
Copy link
Collaborator

@petermakowski petermakowski commented Sep 1, 2023 •
edited

Done

  • fix: restore websocket on error lp#1930001
  • keep current app state on lost websocket connection
  • rename handleMessage, watchMessages to handleWebsocketEvent, watchWebsocketEvents
  • rename socket to rws (reconnecting websocket)

QA

QA steps

  • Checkout this branch locally, and run yarn start
  • Open MAAS UI in the browser and login
  • Go to machine listing, select to add a new machine, enter text into machine name
  • go back to the terminal, close the local web server(e.g. by pressing ctrl+c)
  • verify that "Trying to reconnect..." has been displayed in the browser
  • Go back to the terminal and run yarn start
  • Go to the browser and verify that "Trying to reconnect..." message has disappeared
  • Verify that previously entered text is visible and you can interact with MAAS UI without issues

Launchpad issue

lp#1930001

Screenshots

Google Chrome screenshot 000753@2x

@webteam-app
Copy link

Demo starting at https://maas-ui-5133.demos.haus

@petermakowski petermakowski force-pushed the fix-websocket-connection-keep-alive-lp#1930001 branch from c05e91b to c128c3b Compare September 1, 2023 12:29
@petermakowski petermakowski changed the title fix: keep websocket connection alive lp#231930001 fix: keep websocket connection alive lp#231930001 WIP Sep 1, 2023
@petermakowski petermakowski force-pushed the fix-websocket-connection-keep-alive-lp#1930001 branch 3 times, most recently from 8bd8f91 to d452606 Compare September 1, 2023 13:31
@petermakowski petermakowski changed the title fix: keep websocket connection alive lp#231930001 WIP fix: keep websocket connection alive lp#1930001 WIP Sep 1, 2023
@petermakowski petermakowski force-pushed the fix-websocket-connection-keep-alive-lp#1930001 branch from d452606 to 4163f98 Compare September 1, 2023 13:41
@petermakowski petermakowski changed the title fix: keep websocket connection alive lp#1930001 WIP fix: restore websocket connection on error lp#1930001 WIP Sep 1, 2023
@petermakowski petermakowski force-pushed the fix-websocket-connection-keep-alive-lp#1930001 branch from 4163f98 to 3feb767 Compare September 1, 2023 15:17
@petermakowski petermakowski changed the title fix: restore websocket connection on error lp#1930001 WIP fix: restore websocket connection on error lp#1930001 Sep 1, 2023
@petermakowski petermakowski force-pushed the fix-websocket-connection-keep-alive-lp#1930001 branch from 3feb767 to 61f237b Compare September 1, 2023 15:17
@petermakowski petermakowski marked this pull request as ready for review September 1, 2023 15:18
@petermakowski
fix: restore websocket on error lp#1930001
aa5f8e3 
- keep current app state on lost websocket connection
- rename handleMessage, watchMessages to handleWebsocketEvent, watchWebsocketEvents
- rename socket to rws (reconnecting websocket)
@petermakowski petermakowski force-pushed the fix-websocket-connection-keep-alive-lp#1930001 branch from 61f237b to aa5f8e3 Compare September 1, 2023 15:19
@petermakowski petermakowski merged commit ef81163 into canonical:main Sep 4, 2023
4 checks passed
petermakowski added a commit to petermakowski/maas-ui that referenced this pull request Sep 4, 2023
@petermakowski
fix: restore websocket on error lp#1930001 (canonical#5133)
edfac73 
- keep current app state on lost websocket connection
- rename handleMessage, watchMessages to handleWebsocketEvent, watchWebsocketEvents
- rename socket to rws (reconnecting websocket)
@petermakowski petermakowski mentioned this pull request Sep 4, 2023
Merged
petermakowski added a commit that referenced this pull request Sep 4, 2023
@petermakowski
fix: restore websocket on error lp#1930001 (#5133) (#5138)
01f86a4 
- keep current app state on lost websocket connection
- rename handleMessage, watchMessages to handleWebsocketEvent, watchWebsocketEvents
- rename socket to rws (reconnecting websocket)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jay-Topher Jay-Topher Jay-Topher approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petermakowski @webteam-app @Jay-Topher