fix(websockets): refetch on reconnect MAASENG-2142 #5146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://maas-ui-5146.demos.haus |
petermakowski
force-pushed
the
fix-websockets-refetch-on-reconnect-MAASENG-2142
branch
3 times, most recently
from
3bba209
to
2a01696
Compare
petermakowski
changed the title
petermakowski
force-pushed
the
fix-websockets-refetch-on-reconnect-MAASENG-2142
branch
from
2a01696
to
f81ec26
Compare
petermakowski
changed the title
petermakowski
force-pushed
the
fix-websockets-refetch-on-reconnect-MAASENG-2142
branch
2 times, most recently
from
c5af519
to
116b117
Compare
petermakowski
force-pushed
the
fix-websockets-refetch-on-reconnect-MAASENG-2142
branch
from
116b117
to
7c3f9d6
Compare
petermakowski
force-pushed
the
fix-websockets-refetch-on-reconnect-MAASENG-2142
branch
2 times, most recently
from
5ea8db5
to
4908d34
Compare
Jay-Topher
approved these changes
Sep 7, 2023
- add `useFetchActions` hook - replace `useEffect` with fetch actions on mount with `useFetchActions` - add `connectedCount` to redux store
petermakowski
force-pushed
the
fix-websockets-refetch-on-reconnect-MAASENG-2142
branch
from
4908d34
to
62a8d4b
Compare
ndv99
approved these changes
Sep 7, 2023
petermakowski
added a commit
to petermakowski/maas-ui
that referenced
this pull request
Sep 8, 2023
- add `connectedCount` to redux store - stop WebSocket ping on disconnect - run invalidateQueries on disconnect - run `useFetchActions` hook on reconnect
petermakowski
added a commit
that referenced
this pull request
Sep 8, 2023
#5152) - add `connectedCount` to redux store - stop WebSocket ping on disconnect - run invalidateQueries on disconnect - run `useFetchActions` hook on reconnect - test: update Preferences.test.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
useFetchActionshook that runs a set of actions on mount and every time websocket reconnectsuseEffectwith fetch actions on mount withuseFetchActionsconnectedCountto redux store to keep track of the number of times the websocket has connected successfullyhandlePingStopinvalidateQuerieson websocket disconnect to mark machine list and count requests as staleQA
QA steps
Fixes
Fixes: MAASENG-2142
Launchpad issue
lp#1930001