Create discovered subnet in correct fabric #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a use case: - MAAS's DHCP is disabled, and an external DHCP sever is used for PXE boot. - MAAS has 2 nics, named nic1, nic2. The nic2 is actually the one used for provisioning. - MAAS based on the nic name order, created fabric-0, fabric-1 for them respectively. The fabric-1 is actually the one used for provisioning, while default fabric is fabric-0 which is almost usless. - Commission a node, the node get an ip, the node UI shows its IP as "Auto assigned". - MAAS detected the ip is bound coming from nic2 so it set the node's fabric=1 (more precisely, set vlan_id = id of untagged vlan of fabric-1) - MAAS found the ip is not belonging to any existing subnets, so it automatically create a subnet, but it always create the subnet on fabric-0. This is the begining of all wrong things later. - Deploy the node, also succeeded, when finished, it is node UI shows ip correctly - Release the node, then the node status shows "Node must be attached to a network", this is because it could not find a proper subnet in fabric-1. - The node become unavailable for Deploying unless Commission again. So this PR create such discovered subnet in correct fabric.
|
Thank you for your PR! The code on GitHub is a mirror only and we don't merge PRs here. |
jjqq2013
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a use case:
So this PR create such discovered subnet in correct fabric.