Use pre built zap binary #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farshidtz
reviewed
Oct 25, 2023
farshidtz
reviewed
Oct 26, 2023
snap/snapcraft.yaml
Outdated
|
|
||
| # Install zap | ||
| npm install | ||
| mkdir -p /bin && mv zap-cli /bin |
There was a problem hiding this comment.
Was the bin directory meant to be relative to the current directory, as added to the PATH?
Suggested change
| mkdir -p /bin && mv zap-cli /bin | |
| mkdir -p bin && mv zap-cli bin |
There was a problem hiding this comment.
Please see this comment; the zap-cli doesn't need to be moved to the bin directory.
There was a problem hiding this comment.
It needed to be in the ./bin directory because your environment variables pointed to that:
echo "export ZAP_DEVELOPMENT_PATH=$PWD/bin" >> env
echo "export ZAP_INSTALL_PATH=$PWD/bin" >> env
echo "export PATH=$PWD/bin:$PATH" > env
There was a problem hiding this comment.
According to the doc, ZAP_DEVELOPMENT_PATH and PATH are no longer needed. Only ZAP_INSTALL_PATH needs to point to where zap-linux-arm64.zip was unpacked.
The code is already updated as follows::
wget https://github.com/project-chip/zap/releases/download/$ZAP_VERSION/zap-linux-$SNAP_ARCH.zip
unzip -o zap-linux-$SNAP_ARCH.zip
# Define the environment needed for the app build
echo "export ZAP_INSTALL_PATH=$PWD" >> env
reference: https://project-chip.github.io/connectedhomeip-doc/guides/BUILDING.html#which-zap-to-use According to the above reference, that only |
|
The code can be built successfully on arm64 Pi, but it failed on snapcraft remote-build with the following error: |
farshidtz
reviewed
Oct 27, 2023
The issue isn't related to zap. On remote build, the env file created in Remote build: On Pi: Note that remote build uses Launchpad and as far as I know those builds use the destructive mode, i.e. building directly on the host. The difference in paths appears related to that. |
farshidtz
reviewed
Oct 27, 2023
farshidtz
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR downloads and unzips the prebuilt ZAP (Zigbee Cluster Library configuration tool and generator) binary for the ARM64 architecture, which will make the build more efficient.