Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite lighting-app.zap to remove occupancy sensor #35

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

MonicaisHer
Copy link
Contributor

@MonicaisHer MonicaisHer commented Nov 28, 2023

This PR will resolve #30. This PR depends on the SDK update(#33) to be merged first.

The lighting-app.zap and .matter files are partially generated from: https://github.com/project-chip/connectedhomeip/blob/v1.2.0.1/examples/lighting-app/lighting-common/, with the occupancy sensor part removed.

Reference: flow for updating an application zap file

The snap built from this PR could be install by running:

snap install matter-pi-gpio-commander --channel=latest/edge/pr-35

@farshidtz
Copy link
Member

#33 has been merged.

@MonicaisHer
Copy link
Contributor Author

MonicaisHer commented Dec 1, 2023

I have tested and confirmed that the occupancy sensor no longer exists in the snap. Below is a comparison result of reading the occupancy sensor from channels edge and edge/pr-35.

Logs of chip-tool controlling commander snap from edge (occupancy sensor exists):

$ sudo snap install matter-pi-gpio-commander --channel=latest/edge
$ sudo chip-tool occupancysensing read occupancy 110 1
...
CHIP:TOO:   Occupancy: 0

Logs of chip-tool controlling commander snap from edge/pr-35 (occupancy sensor removed):

$ sudo snap install matter-pi-gpio-commander --channel=latest/edge/pr-35
$ sudo chip-tool occupancysensing read occupancy 110 1
...
CHIP:TOO: Response Failure: IM Error 0x000005C3: General error: 0xc3 (UNSUPPORTED_CLUSTER)
CHIP:TOO: Run command failure: IM Error 0x000005C3: General error: 0xc3 (UNSUPPORTED_CLUSTER)

snap/snapcraft.yaml Outdated Show resolved Hide resolved
@farshidtz farshidtz merged commit 96a909c into canonical:main Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commander advertising an occupancy sensor
2 participants