Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the log manipulation facilities. #307

Merged
merged 11 commits into from
Feb 23, 2024
Merged

Document the log manipulation facilities. #307

merged 11 commits into from
Feb 23, 2024

Conversation

lmlg
Copy link
Contributor

@lmlg lmlg commented Feb 20, 2024

No description provided.

@lmlg
Document the log manipulation facilities.
acb1970 
Signed-off-by: Luciano Lo Giudice <luciano.logiudice@canonical.com>
@lmlg
Spelling fix.
058dd3c 
Signed-off-by: Luciano Lo Giudice <luciano.logiudice@canonical.com>
@lmlg
More spelling fixes.
2db609a 
Signed-off-by: Luciano Lo Giudice <luciano.logiudice@canonical.com>
@lmlg
Spell: subcommand -> sub command
1e7ff9e 
Signed-off-by: Luciano Lo Giudice <luciano.logiudice@canonical.com>
@lmlg
Spell: prohibitely high -> far too high
e7ad3c9 
Signed-off-by: Luciano Lo Giudice <luciano.logiudice@canonical.com>
@lmlg
Spell: get-lvel => get-level
5764323 
Signed-off-by: Luciano Lo Giudice <luciano.logiudice@canonical.com>
sabaini
sabaini requested changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@sabaini sabaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Two minor branding nits / suggestions

docs/how-to/change-log-level.rst Outdated Show resolved Hide resolved
docs/how-to/change-log-level.rst Outdated Show resolved Hide resolved
UtkarshBhatthere
UtkarshBhatthere requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@UtkarshBhatthere UtkarshBhatthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor nit

@lmlg
Small changes in doc file
58cfdb5 
Signed-off-by: Luciano Lo Giudice <luciano.logiudice@canonical.com>
@lmlg
Use camelcase for MicroCeph
5777133 
Signed-off-by: Luciano Lo Giudice <luciano.logiudice@canonical.com>
pmatulis
pmatulis suggested changes Feb 21, 2024
View reviewed changes
docs/how-to/change-log-level.rst Outdated Show resolved Hide resolved
docs/how-to/change-log-level.rst Outdated Show resolved Hide resolved
docs/how-to/change-log-level.rst Outdated Show resolved Hide resolved
docs/how-to/change-log-level.rst Outdated Show resolved Hide resolved
@lmlg
Address PR comments
ca6752f 
Signed-off-by: Luciano Lo Giudice <luciano.logiudice@canonical.com>
@lmlg
Fix typo
e83c365 
Signed-off-by: Luciano Lo Giudice <luciano.logiudice@canonical.com>
pmatulis
pmatulis suggested changes Feb 21, 2024
View reviewed changes
docs/how-to/change-log-level.rst Outdated Show resolved Hide resolved
@lmlg
Simplify title.
8788358 
Signed-off-by: Luciano Lo Giudice <luciano.logiudice@canonical.com>
UtkarshBhatthere
UtkarshBhatthere approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@UtkarshBhatthere UtkarshBhatthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmlg lmlg merged commit bfd9424 into main Feb 23, 2024
18 of 19 checks passed
@lmlg lmlg deleted the doc-log-level branch February 23, 2024 22:50
@sabaini sabaini mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabaini sabaini sabaini requested changes

@pmatulis pmatulis pmatulis requested changes

@UtkarshBhatthere UtkarshBhatthere UtkarshBhatthere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lmlg @sabaini @pmatulis @UtkarshBhatthere