Preseed yaml #164
Merged
Preseed yaml #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just dropped a somewhat descriptive yaml under the |
tomponline
reviewed
Sep 20, 2023
masnax
force-pushed
the
preseed-yaml
branch
from
06eaf90
to
35594d7
Compare
|
@masnax did you want a review of this now? |
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
masnax
force-pushed
the
preseed-yaml
branch
from
35594d7
to
1115b36
Compare
|
@tomponline Yeah, that would be great thanks. |
tomponline
reviewed
Sep 26, 2023
| // - If `autoSetup` is true, all systems found in the first 5s will be recorded, and no other input is required. | ||
| // - `expectedSystems` is a list of expected hostnames. If given, the behaviour is similar to `autoSetup`, | ||
| // except it will wait up to a minute for exclusively these systems to be recorded. | ||
| func lookupPeers(s *service.Handler, autoSetup bool, subnet *net.IPNet, expectedSystems []string, systems map[string]InitSystem) error { |
There was a problem hiding this comment.
Thanks for the comment, this explains it well.
This isn't a blocker, just a nit, but the coupling of different timeouts with different modes feels quite peculiar for a utility function like this.
For future reference pushing the timeout decision to the caller and just having a ctx or timeout argument here would make the function description cleaner to understand and separate the concerns of what the function should do by when.
tomponline
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for preseed init