Match cluster sizes before adding disks #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom services Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
…trapping Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
For larger clusters (10+), we time out too early and not all peers have time to join. Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
masnax
force-pushed
the
match-clusters
branch
from
58dfce7
to
4dd206c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check after bootstrapping the cluster to ensure all services have the same cluster size before attempting to add disks.
Additionally, watching the new video on MicroCloud made me realize the cluster formation timeout was a bit too short at 1 minute. Only 6 out of the 10 peers reported having joined the cluster. So there's a commit that bumps the timeout up to 5 minutes.