-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init updates #6
Init updates #6
Conversation
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
This is so we don't get a client earlier than we need it. Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
StoragePools: []api.StoragePoolsPost{storage}, | ||
Profiles: []api.ProfilesPost{profile}, | ||
}, | ||
initData := initDataNode{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@masnax out of interest, why not use api.InitLocalPreseed here? They look the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initDataNode
struct seems unnecessary, but I don't want to hold this PR up, so approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, you did use the newly exported structs, you just did a revert first. Makes sense.
This addresses @stgraber's comments from IRC:
ConnectLXD
right away.initDataNodeApply
from LXD with the project related parts stripped out.zfs
for the storage driverlxdfan0
network device