Do not set --hostname-override on kube-proxy when joining a cluster #4360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoaggelos
added a commit
that referenced
this pull request
Jan 12, 2024
neoaggelos
added a commit
that referenced
this pull request
Jan 12, 2024
neoaggelos
added a commit
that referenced
this pull request
Jan 12, 2024
neoaggelos
added a commit
that referenced
this pull request
Jan 12, 2024
neoaggelos
added a commit
that referenced
this pull request
Jan 12, 2024
neoaggelos
added a commit
that referenced
this pull request
Jan 12, 2024
neoaggelos
added a commit
that referenced
this pull request
Jan 12, 2024
neoaggelos
added a commit
that referenced
this pull request
Jan 12, 2024
neoaggelos
added a commit
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4345
Needs backport on all supported tracks
kube-proxymust be configured to use the same node name askubelet, otherwise services with Local external traffic policy fail to forward traffic (since node name of endpoints does not match the node name of the proxy).Description
In the past (for non HA), we would set
--hostname-overrideflags on both kube-proxy and kubelet services. In recent times, we do not need to do this, and we end in a situation where kubelet is running with its proper hostname, but kube-proxy still tries to find a node with the IP as name (which does not exist).For more details, see #4345 (comment)
Change
--hostname-overrideflag on the kube-proxy when joining a cluster. We would only do this if we set this flag for kubelet as well, but we don't.Testing
Locally