Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest discourse module to fix caching issue #233

Merged

Conversation

nottrobin
Copy link
Contributor

@nottrobin nottrobin commented Jun 12, 2023

Microstack.run is using the bad version of canonicalwebteam.discourse which leads to index page caching.

Fixes https://warthogs.atlassian.net/browse/WD-4503
Fixes canonical/canonicalwebteam.discourse#165

QA

Go to https://microstack-run-233.demos.haus/docs. Change some content. Refresh.

Bear in mind that page rules set cache timeout to 1 minute anyway, so it might take 1 minute for your browser to show you the latest version.

@webteam-app
Copy link

Demo starting at https://microstack-run-233.demos.haus

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #233 (7d5b65f) into main (730fb19) will not change coverage.
The diff coverage is n/a.

❗ Current head 7d5b65f differs from pull request most recent head 8160485. Consider uploading reports for the commit 8160485 to get more accurate results

@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   77.27%   77.27%           
=======================================
  Files           2        2           
  Lines          44       44           
=======================================
  Hits           34       34           
  Misses         10       10           
Flag Coverage Δ
python 77.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@samhotep samhotep self-requested a review June 12, 2023 09:32
@anthonydillon anthonydillon merged commit 807f657 into canonical:main Jun 12, 2023
7 checks passed
@nottrobin nottrobin deleted the update-discourse-docs-module branch June 13, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation on microstack.run is not being updated
5 participants