Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #51.
Solution
This PR adds support for the ingress relation. It's worth noting that the
external_url
is only used for:PrometheusRemoteWriteProvider
.It's not used for the self-monitoring prometheus-scrape relation(s), because those are meant to be "in model" only.
The PR also adds the nginx configuration generation to mimir-cluster-changed events, to regenerate it when the worker cluster changes.