Skip to content

Commit

Permalink
Merge #1809
Browse files Browse the repository at this point in the history
1809: gbm-kms: Disable bypass by default. r=AlanGriffiths a=RAOF

This triggers a GPU OOM (issue #1801) on the Pi3 when used with default settings.
There may be due to us hanging on to buffers longer than they need to be, but
it's not clear yet.

Users who want the performance boost and are running on known hardware can
set `--bypass=true`, but by default use the safe option of `false`.

Co-authored-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
  • Loading branch information
2 people authored and AlanGriffiths committed Nov 12, 2020
1 parent 505ad34 commit 56624c1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/platforms/gbm-kms/server/kms/platform_symbols.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ void add_graphics_platform_options(boost::program_options::options_description&
mir::assert_entry_point_signature<mg::AddPlatformOptions>(&add_graphics_platform_options);
config.add_options()
(bypass_option_name,
boost::program_options::value<bool>()->default_value(true),
boost::program_options::value<bool>()->default_value(false),
"[platform-specific] utilize the bypass optimization for fullscreen surfaces.");
}

Expand Down

0 comments on commit 56624c1

Please sign in to comment.