Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable WLCS tests on LP/arm* (as they are currently flaky) #2488

Closed
wants to merge 1 commit into from
Closed

Disable WLCS tests on LP/arm* (as they are currently flaky) #2488

wants to merge 1 commit into from

Conversation

AlanGriffiths
Copy link
Contributor

Workaround: #2474

wmww
wmww approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@wmww wmww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea, but not sure if I'm the one to approve it
bors delegate+

@bors
Copy link
Contributor

bors bot commented Jun 22, 2022

✌️ AlanGriffiths can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@RAOF
Copy link
Contributor

RAOF commented Jun 23, 2022

We'll experiment with trying qemu from 22.04 and see if that makes things more stable before landing this.

@Saviq
Copy link
Collaborator

Saviq commented Jun 23, 2022

#2490

Saviq
Saviq reviewed Jun 23, 2022
View reviewed changes
debian/rules
Comment on lines +45 to +48
# Disable wlcs tests on Launchpad armhf, arm64 (MirServer/mir#2474)
ifneq ($(filter armhf arm64,$(DEB_HOST_ARCH)),)
COMMON_CONFIGURE_OPTIONS += -DMIR_RUN_WLCS_TESTS=OFF
endif
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If at all, we should only disable them when cross-building - which is where we see those failures.

But let's see where does #2490 take us.

@AlanGriffiths
Copy link
Contributor Author

#2490 is a much better solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saviq Saviq Saviq left review comments

@wmww wmww wmww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AlanGriffiths @RAOF @Saviq @wmww