Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: get sanitizer results #2926

Draft
wants to merge 1 commit into
base: ci-enable-asan
Choose a base branch
from
Draft

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented May 12, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (ci-enable-asan@3b9fe2d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 5d644fc differs from pull request most recent head a4a7f3c. Consider uploading reports for the commit a4a7f3c to get more accurate results

@@                Coverage Diff                @@
##             ci-enable-asan    #2926   +/-   ##
=================================================
  Coverage                  ?   77.70%           
=================================================
  Files                     ?     1056           
  Lines                     ?    73394           
  Branches                  ?        0           
=================================================
  Hits                      ?    57034           
  Misses                    ?    16360           
  Partials                  ?        0           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@Saviq Saviq self-assigned this May 12, 2023
@Saviq Saviq force-pushed the get-sanitizer-results branch 3 times, most recently from c643d00 to f395fb2 Compare May 12, 2023 16:28
@RAOF
Copy link
Contributor

RAOF commented Jun 5, 2023

Ok. So, UBSan looks like it should be good to add to the block-CI set; we don't invoke any behaviour it can detect as UB.

We should be able to turn on ASan and disable leak checking, but

  • The gcc asan build is baroquen.
  • The clang asan build picks up some legitimate bugs - ODR violations, something maybe broken in ShmMapping::CurrentMapping, and maybe a UAF in ObserverMultiplexer - and then something in the UDevWrapperDeathTest, which may well just be a false positive.

So, current status: We should add UBsan to the list off builds required to pass in CI, and fix the bugs that asan detects.

@Saviq Saviq force-pushed the get-sanitizer-results branch 10 times, most recently from 1832636 to 31238ed Compare August 30, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants