Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: re-do the mir test plan #3392

Merged
merged 9 commits into from
May 30, 2024
Merged

docs: re-do the mir test plan #3392

merged 9 commits into from
May 30, 2024

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented May 21, 2024

Click https://canonical-mir--3392.com.readthedocs.build/3392/how-to/how-to-test-mir-for-a-release/ to read the content

What's new?

To follow

  1. Integrate 2.16 findings into this test plan
  2. Integrate hybrid wack-a-mole findings into this test plan

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.51%. Comparing base (e0c46a0) to head (91ec04a).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3392      +/-   ##
==========================================
- Coverage   77.53%   77.51%   -0.03%     
==========================================
  Files        1075     1065      -10     
  Lines       68300    67914     -386     
==========================================
- Hits        52959    52642     -317     
+ Misses      15341    15272      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattkae mattkae changed the title (wip, don't review) beginning docs on how to test Mir docs: moving the test plan to readthedocs May 22, 2024
@mattkae mattkae marked this pull request as ready for review May 22, 2024 20:06
@mattkae mattkae requested a review from a team as a code owner May 22, 2024 20:06
Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not "(mostly) a reorganization and categorization of the previous test plan".

The previous test plans details testing the Mir release candidate from ppa:mir-team/rc. There is a separate "test plan" that says we should also test mir-test-tools, ubuntu-frame, confined-shell and miriway. (But only details testing mir-test-tools). I don't think conflating these (and dropping testing of Frame and confined-shell) is helpful.

doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
@mattkae mattkae changed the title docs: moving the test plan to readthedocs docs: re-do the mir test plan May 24, 2024
doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
5. When you are running the compositor hosted in a session that supports wayland
_and_ you force Mir to use the `mir:wayland` platform using:
```
miral-app --platform-display-libs=mir:wayland --wayland-host=$WAYLAND_DISPLAY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that we need to force the wayland platform? --wayland-host=… should be enough?

doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
mattkae and others added 2 commits May 28, 2024 07:36
Co-authored-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
@mattkae mattkae requested a review from RAOF May 28, 2024 11:49
doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More nitpicking

doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
Comment on lines 75 to 76
1. Run the `mir-test-smoke-runner` and confirm that the final output is:
`Smoke testing complete with returncode 0`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should state explicitly how to control the platform selected by the smoke tests.

E.g. testing on the virtual platform doesn't need to connect a VNC client (as described in the previous section), and it is easiest to use environment variables to select the platform:

MIR_SERVER_PLATFORM_DISPLAY_LIBS=mir:virtual MIR_SERVER_VIRTUAL_OUTPUT=1280x1024 mir-smoke-test-runner

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, it might be better to use environment variables throughout.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept a few as commandline params (e.g. --console-providers and --vt, but the others are now env variables)

doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved
Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit more tweaking

doc/sphinx/how-to/how-to-test-mir-for-a-release.md Outdated Show resolved Hide resolved

## Mir Console Providers

Run with different console providers and ensure that the compositor can start:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Run with different console providers and ensure that the compositor can start:
For each Ubuntu release ensure that the compositor can start with each of the console providers:

Comment on lines 135 to 153
```sh
miral-app --console-provider=vt --vt=4
```
- This requires running with root privileges
- You need to ensure that `XDG_RUNTIME_DIR` is set in the environment. If using `sudo`,
it might strip this out; running something like `sudo env XDG_RUNTIME_DIR=/run/user/1000 miral-shell ...`
will ensure this is set.

```sh
miral-app --console-provider=logind
```
- You can switch to vt4 and sign in

```sh
miral-app --console-provider=minimal
```
- This is used when all others fail
- This does not provide VT switching capabilities (Ctrl-Alt-F1, etc)
- This is _only_ used for the `gbm-x11`, `gbm-wayland`, and `virtual` platforms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be better structured (similar to "Testing each graphics platform"), but OK for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made them match better

mattkae and others added 2 commits May 30, 2024 07:03
Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not perfect, but a useful improvement

@AlanGriffiths AlanGriffiths added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit cc748ac May 30, 2024
22 of 25 checks passed
@AlanGriffiths AlanGriffiths deleted the docs/how_to_test_mir branch May 30, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants