Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add Mir's CI documentation #3434

Merged
merged 6 commits into from
Jun 27, 2024
Merged

doc: add Mir's CI documentation #3434

merged 6 commits into from
Jun 27, 2024

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Jun 20, 2024

No description provided.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (b526b15) to head (5498da2).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3434      +/-   ##
==========================================
- Coverage   77.24%   77.23%   -0.01%     
==========================================
  Files        1071     1071              
  Lines       68468    68467       -1     
==========================================
- Hits        52890    52883       -7     
- Misses      15578    15584       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saviq Saviq force-pushed the MIRENG-528-doc-ci branch 8 times, most recently from 224cc17 to 89b7cbe Compare June 21, 2024 13:33
@Saviq Saviq changed the title doc: first pieces of CI documentation doc: add Mir's CI documentation Jun 26, 2024
@Saviq Saviq marked this pull request as ready for review June 26, 2024 15:48
@Saviq Saviq requested a review from a team as a code owner June 26, 2024 15:48
@Saviq Saviq requested a review from mattkae June 26, 2024 16:10
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions 😄

The content mostly makes sense to me

doc/sphinx/reference/continuous-integration.md Outdated Show resolved Hide resolved
doc/sphinx/reference/continuous-integration.mmd Outdated Show resolved Hide resolved
doc/sphinx/reference/continuous-integration.md Outdated Show resolved Hide resolved
doc/sphinx/reference/continuous-integration.md Outdated Show resolved Hide resolved
doc/sphinx/reference/continuous-integration.md Outdated Show resolved Hide resolved
doc/sphinx/reference/continuous-integration.md Outdated Show resolved Hide resolved
doc/sphinx/reference/continuous-integration.md Outdated Show resolved Hide resolved
- set the stage better
- better wording all around
- use "merge" rather than "push", since we require that for `main` and
  `release/`
- clarify ubsan

Co-Authored-By: Matthew Kosarek <matthew.kosarek@canonical.com>
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good by me!

@mattkae mattkae added this pull request to the merge queue Jun 27, 2024
Merged via the queue into main with commit 6108f2a Jun 27, 2024
32 of 36 checks passed
@mattkae mattkae deleted the MIRENG-528-doc-ci branch June 27, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants