Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mir release 1.1 #659

Merged
merged 13 commits into from
Dec 18, 2018
Merged

Mir release 1.1 #659

merged 13 commits into from
Dec 18, 2018

Conversation

AlanGriffiths
Copy link
Contributor

No description provided.

@AlanGriffiths
Copy link
Contributor Author

18.04: pass https://wiki.ubuntu.com/Process/Merges/TestPlans/Mir

@AlanGriffiths
Copy link
Contributor Author

18.10: pass https://wiki.ubuntu.com/Process/Merges/TestPlans/Mir

@AlanGriffiths
Copy link
Contributor Author

16.04: pass https://wiki.ubuntu.com/Process/Merges/TestPlans/Mir

@AlanGriffiths
Copy link
Contributor Author

19.04: pass https://wiki.ubuntu.com/Process/Merges/TestPlans/Mir

@AlanGriffiths
Copy link
Contributor Author

@RAOF @gerboland could someone with Nvidia kit please check ppa:mir-team/rc works as expected?

@AlanGriffiths
Copy link
Contributor Author

We should fix #661 before release

@AlanGriffiths
Copy link
Contributor Author

We also need to solve #662

@RAOF
Copy link
Contributor

RAOF commented Dec 10, 2018

The new build should fix #662; the egl-wayland package is no longer broken, so #661 is also fixed.

AlanGriffiths and others added 8 commits December 14, 2018 20:45
@AlanGriffiths
We've no mirclient platform for eglstream-kms. Drop the legacy code f…
ea21fa1 
…or it.
@RAOF @AlanGriffiths
Also drop the test for probing the now-nonexistent eglstream client p…
0c8bf7e 
…latform
@bors @RAOF @AlanGriffiths
Merge #660
0f52c4a 
660: ThreadedDRMEventHandlerTest: Make ThreadSanitizer happy. r=AlanGriffiths a=RAOF

We were interleaving calls to EXPECT_CALL(…, drmHandleEvent) with calls to drmHandleEvent *in a different thread*, which really just makes you wonder how it worked at all.

Co-authored-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
@bors @RAOF @AlanGriffiths
Merge #665
00b25c9 
665: miral/eglapp: Accept EGL versions ≥ 1.4 r=gerboland a=RAOF

There's no need to reject EGL 1.5 here.

Since the NVIDIA driver now supports 1.5, this causes the spinner
to bail on startup on the eglstream-kms platform. (Fixes #661)

Co-authored-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
@bors @AlanGriffiths
Merge #667
498470e 
667: Strip out legacy titlebar logic r=RAOF a=AlanGriffiths

This simplifies the DecorationProvider code. (The mirclient API based "titlebar" logic ignores Wayland clients anyway).

We need to follow up with something similar to #666: This is the final "internal clients" needing to be migrated from the mirclient API to Wayland.

(Needed to function on Nvidia as mirclient API doesn't work on Nvidia.)

Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
@bors @AlanGriffiths @wmww
Merge #666
1002c46 
666: Rework the miral-kiosk splash screen to use Wayland r=RAOF a=AlanGriffiths

This is the first of the "internal clients" to be migrated from the mirclient API to Wayland.

(Needed to function on Nvidia as mirclient API doesn't work on Nvidia.)

Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
Co-authored-by: William Wold <wm@wmww.sh>
@bors @AlanGriffiths @RAOF
Merge #669
edf579c 
669: Rework the miral-shell background to use Wayland r=gerboland a=AlanGriffiths



Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
Co-authored-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
@AlanGriffiths
We've no mirclient platform for eglstream-kms. Drop the legacy code f…
d457416 
…or it. (#668)

* We've no mirclient platform for eglstream-kms. Drop the legacy code for it.

* Also drop the test for probing the now-nonexistent eglstream client platform
@AlanGriffiths
Copy link
Contributor Author

16.04: pass https://wiki.ubuntu.com/Process/Merges/TestPlans/Mir

@AlanGriffiths
Copy link
Contributor Author

18.10: pass https://wiki.ubuntu.com/Process/Merges/TestPlans/Mir

@AlanGriffiths
Copy link
Contributor Author

\o/ I now have a way to reproduce the message @gerboland saw last week:

[2018-12-17 10:14:46.872497] <CRITICAL> frontend:Wayland: Exception processing Surface::commit() request: /build/mir-fN5xrV/mir-1.1.0~rc12-gd4574168b8/src/miral/basic_window_manager.cpp(1949): Throw in function void miral::BasicWindowManager::validate_modification_request(const miral::WindowSpecification&, const miral::WindowInfo&) const
Dynamic exception type: boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<std::runtime_error> >
std::exception::what: width must be positive

On 18.10 I ran:

$ miral-desktop -kiosk

then ran some programs and exited. The above appeared in the log.

@AlanGriffiths
Copy link
Contributor Author

19.04: pass https://wiki.ubuntu.com/Process/Merges/TestPlans/Mir

@bors @AlanGriffiths @RAOF
Merge #670
adae06a 
670: [miral-shell] DecorationProvider: Respond to output events r=gerboland a=AlanGriffiths

This fixes the background when the screen is rotated left or right:

    miral-app

(in the session)

    mirout output 1 rotate left

The client wasn't receiving notifications of output reconfiguration because it wasn't running an event loop.

Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
Co-authored-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
@AlanGriffiths
Copy link
Contributor Author

18.04: pass https://wiki.ubuntu.com/Process/Merges/TestPlans/Mir

@RAOF
Copy link
Contributor

RAOF commented Dec 18, 2018

19.04: pass (eglstreams-kms)

@RAOF
Copy link
Contributor

RAOF commented Dec 18, 2018

Although we might want to cherry-pick #678

@AlanGriffiths
Copy link
Contributor Author

@RAOF Although we might want to cherry-pick #678

I'd prefer not to add any more changes, and we've done a lot of testing without: this can it wait?

@RAOF
Copy link
Contributor

RAOF commented Dec 18, 2018 •
edited

@RAOF Although we might want to cherry-pick #678

I'd prefer not to add any more changes, and we've done a lot of testing without: this can it wait?

Yes; the bug that fixes doesn't prevent Mir from working, it just fails to prevent Mir from trying to work on NVIDIA driver versions Gerry found not to work (and adds a harmless warning message).

@AlanGriffiths
Copy link
Contributor Author

18.10: pass https://wiki.ubuntu.com/Process/Merges/TestPlans/Mir

Also, mir-smoke-test-runner passed on 19.04 mesa-kms and mesa-x11

RAOF
RAOF approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RAOF
Copy link
Contributor

RAOF commented Dec 18, 2018

bors r+

bors bot added a commit that referenced this pull request Dec 18, 2018
@bors @AlanGriffiths @RAOF
Merge #659
bc88f51 
659: Mir release 1.1 r=RAOF a=AlanGriffiths



Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
Co-authored-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
Co-authored-by: bors[bot] <bors[bot]@users.noreply.github.com>
@AlanGriffiths
Copy link
Contributor Author

16.04: pass https://wiki.ubuntu.com/Process/Merges/TestPlans/Mir

@bors
Copy link
Contributor

bors bot commented Dec 18, 2018

Build failed

@Saviq
Copy link
Collaborator

Saviq commented Dec 18, 2018

bors r=RAOF

bors bot added a commit that referenced this pull request Dec 18, 2018
@bors @AlanGriffiths @RAOF
Merge #659
a3fcae2 
659: Mir release 1.1 r=RAOF a=AlanGriffiths



Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
Co-authored-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
Co-authored-by: bors[bot] <bors[bot]@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Dec 18, 2018

Build succeeded

@bors bors bot merged commit adae06a into master Dec 18, 2018
@bors bors bot deleted the release/1.1 branch December 18, 2018 11:58
AlanGriffiths added a commit that referenced this pull request Feb 13, 2019
@bors @AlanGriffiths @RAOF
Merge #659
e5a4d67 
659: Mir release 1.1 r=RAOF a=AlanGriffiths



Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
Co-authored-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
Co-authored-by: bors[bot] <bors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RAOF RAOF RAOF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlanGriffiths @RAOF @Saviq