Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-1720] Add backups to k8s charm and configure PBM #172

Merged
merged 13 commits into from
Jul 22, 2023

Conversation

dmitry-ratushnyy
Copy link
Contributor

@dmitry-ratushnyy dmitry-ratushnyy commented Jun 27, 2023

About

The goal of this PR is to

  • add backup library to MongoDB K8S charm
  • configure PBM
  • Add unit and integration tests for PBM configuration

Related issues

DPE-1720, DPE-1957

@dmitry-ratushnyy dmitry-ratushnyy force-pushed the dmitry.ratsuhnyy/add_backup branch 3 times, most recently from 808141f to 2b4d7e0 Compare June 28, 2023 08:03
@dmitry-ratushnyy dmitry-ratushnyy changed the title [WIP] Add backups to k8s charm [WIP] [DPE-1720] Add backups to k8s charm Jun 28, 2023
@dmitry-ratushnyy dmitry-ratushnyy changed the title [WIP] [DPE-1720] Add backups to k8s charm [WIP][DPE-1720] Add backups to k8s charm Jun 28, 2023
@dmitry-ratushnyy dmitry-ratushnyy force-pushed the dmitry.ratsuhnyy/add_backup branch 2 times, most recently from 51b2ca1 to b303c3c Compare June 29, 2023 08:16
@dmitry-ratushnyy dmitry-ratushnyy force-pushed the dmitry.ratsuhnyy/add_backup branch 8 times, most recently from 7a8b350 to 9c08694 Compare July 12, 2023 16:51
@dmitry-ratushnyy dmitry-ratushnyy changed the title [WIP][DPE-1720] Add backups to k8s charm [DPE-1720] Add backups to k8s charm and configure PBM Jul 13, 2023
@dmitry-ratushnyy dmitry-ratushnyy force-pushed the dmitry.ratsuhnyy/add_backup branch 4 times, most recently from 0642537 to 8befeaa Compare July 13, 2023 17:54
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is copied from VM charm

@dmitry-ratushnyy dmitry-ratushnyy force-pushed the dmitry.ratsuhnyy/add_backup branch 3 times, most recently from b2e486a to 57b2811 Compare July 14, 2023 04:58
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Outdated Show resolved Hide resolved
delgod
delgod previously approved these changes Jul 14, 2023
Copy link

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use some more refinements

@dmitry-ratushnyy
Copy link
Contributor Author

could use some more refinements

for example? 😄

Mehdi-Bendriss
Mehdi-Bendriss previously approved these changes Jul 14, 2023
Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just minor nits and perhaps some questions

lib/charms/mongodb/v0/helpers.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/helpers.py Show resolved Hide resolved
lib/charms/mongodb/v0/helpers.py Outdated Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Show resolved Hide resolved
lib/charms/mongodb/v0/mongodb_backups.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
delgod
delgod previously approved these changes Jul 14, 2023
Mehdi-Bendriss
Mehdi-Bendriss previously approved these changes Jul 15, 2023
@delgod delgod dismissed stale reviews from Mehdi-Bendriss and themself via 6cf8997 July 22, 2023 05:16
@delgod delgod force-pushed the dmitry.ratsuhnyy/add_backup branch from 2e51fe5 to 61ab709 Compare July 22, 2023 14:35
@delgod delgod merged commit f887459 into main Jul 22, 2023
11 checks passed
@delgod delgod deleted the dmitry.ratsuhnyy/add_backup branch July 22, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants