[DPE-2320] fix monitor secret id parsing issue #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delgod
changed the title
delgod
force-pushed
the
test-monitor-secret
branch
from
9c01a8d
to
77a1dde
Compare
|
tests passed on juju3 here - https://github.com/canonical/mongodb-k8s-operator/actions/runs/5631150298?pr=181 |
delgod
force-pushed
the
test-monitor-secret
branch
from
77a1dde
to
bfad431
Compare
delgod
force-pushed
the
test-monitor-secret
branch
2 times, most recently
from
ccc2379
to
5c69c35
Compare
dmitry-ratushnyy
previously approved these changes
Jul 24, 2023
delgod
force-pushed
the
test-monitor-secret
branch
from
5c69c35
to
851b5cf
Compare
dmitry-ratushnyy
previously approved these changes
Jul 26, 2023
juditnovak
requested changes
Jul 27, 2023
There was a problem hiding this comment.
I'm wondering if we should have a test (both for unit and app) which would have failed w/o the fix, and which is checking that the functionality of this fix is preserved in the future, no? It may be a bit complex as an integration test (due to eventual consistency), but should be well feasable as a unittest.
juditnovak
dismissed stale reviews from shayancanonical and dmitry-ratushnyy
via
73135e2
juditnovak
approved these changes
Jul 27, 2023
|
Juju 3 pipeline: #183 |
juditnovak
changed the title
|
Juju 3.2.0.1 tests passed here after the refactor: https://github.com/canonical/mongodb-k8s-operator/actions/runs/5693032447 |
dmitry-ratushnyy
approved these changes
Jul 31, 2023
shayancanonical
approved these changes
Jul 31, 2023
juditnovak
force-pushed
the
test-monitor-secret
branch
from
73135e2
to
df36fd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes secret id is represented in different ways https://bugs.launchpad.net/juju/+bug/2028402.
this PR workaround the juju issue.