-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-2320] fix monitor secret id parsing issue #181
Conversation
9c01a8d
to
77a1dde
Compare
tests passed on juju3 here - https://github.com/canonical/mongodb-k8s-operator/actions/runs/5631150298?pr=181 |
77a1dde
to
bfad431
Compare
ccc2379
to
5c69c35
Compare
5c69c35
to
851b5cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great regex!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should have a test (both for unit and app) which would have failed w/o the fix, and which is checking that the functionality of this fix is preserved in the future, no? It may be a bit complex as an integration test (due to eventual consistency), but should be well feasable as a unittest.
73135e2
Juju 3 pipeline: #183 |
Juju 3.2.0.1 tests passed here after the refactor: https://github.com/canonical/mongodb-k8s-operator/actions/runs/5693032447 |
73135e2
to
df36fd9
Compare
Sometimes secret id is represented in different ways https://bugs.launchpad.net/juju/+bug/2028402.
this PR workaround the juju issue.