Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli/info] multipass info --all does not list deleted instances #2936

Closed
andrei-toterman opened this issue Feb 28, 2023 · 6 comments · Fixed by #2966
Closed

[cli/info] multipass info --all does not list deleted instances #2936

andrei-toterman opened this issue Feb 28, 2023 · 6 comments · Fixed by #2966
Assignees
@andrei-toterman
Labels
bug good first issue
Milestone
1.12.0

Comments

@andrei-toterman
Copy link
Contributor

Describe the bug
Listing information about all instances does not include deleted instances. multipass info works on a deleted instance, multipass ls includes deleted instances, so multipass info --all should include the deleted instances info as well.

To Reproduce

  1. multipass launch -n test
  2. multipass delete test
  3. multipass info test shows info about deleted instance
  4. multipass info --all does not show info about the deleted instance

Expected behavior
Show info about all instances on multipass info --all

Additional info

  • OS: any
  • multipass version 1.11.1
  • multipass get local.driver any
@Aryansingh0103
Copy link

I would like to work on this can you please assign me this work @andrei-toterman

@Aryansingh0103
Copy link

Sir can you help me by suggesting where this file is as I am searching for it, I just want to know where the file is

@andrei-toterman
Copy link
Contributor Author

Sure! You should look inside src/daemon/daemon.cpp.

@georgeliao
Copy link
Contributor

Since multipass info --all does show the state of the instance, it makes sense to show the deleted instances as well. Apart from that, the fact that you manually run it and find it out this behavior does not seem to be right. My wondering is that whether this can be unit tested. If so, maybe unit tests should be added.

@ricab
Copy link
Contributor

ricab commented Mar 2, 2023

Indeed, this should be covered by unit tests. We have been steadily improving our test coverage over the years, but there are still blind spots. I agree that implementing tests for this should be part of fixing this issue.

@Aryansingh0103
Copy link

thankyou sir, I think my code will work but it has some flaws also in it but I'm still trying to improve it .

@andrei-toterman andrei-toterman mentioned this issue Mar 14, 2023
Merged
bors bot added a commit that referenced this issue Mar 20, 2023
@bors @andrei-toterman
Merge #2966
8d62659 
2966: [daemon] include deleted instances in `info --all` reply r=sharder996 a=andrei-toterman

fix #2936

Co-authored-by: Andrei Toterman <andrei.toterman@canonical.com>
bors bot added a commit that referenced this issue Mar 21, 2023
@bors @andrei-toterman
Merge #2966
73e207e 
2966: [daemon] include deleted instances in `info --all` reply r=sharder996 a=andrei-toterman

fix #2936

Co-authored-by: Andrei Toterman <andrei.toterman@canonical.com>
@townsend2010 townsend2010 added this to the 1.12.0 milestone Mar 22, 2023
@bors bors bot closed this as completed in ecb44e0 Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrei-toterman andrei-toterman

Labels
bug good first issue
Projects
None yet
Milestone
1.12.0
Development

Successfully merging a pull request may close this issue.

[daemon] include deleted instances in info --all reply canonical/multipass
5 participants
@georgeliao @ricab @townsend2010 @andrei-toterman @Aryansingh0103