Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strange issue with mount #77

Closed
marosg42 opened this issue Jan 27, 2018 · 1 comment
Closed

strange issue with mount #77

marosg42 opened this issue Jan 27, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@marosg42
Copy link

I cloned a repo from github, without any other actions when I try to checkout my branch it says I have modified files. Plus see how long it took to report the problem. It is also interesting there is that automatic step of checkout 1090 files which does not happen when not in mounted dir.

$ rm -rf mate-applets/
$ ll
total 8
drwxrwxr-x  1 ubuntu ubuntu 4096 Jan 27 13:51 ./
drwxr-xr-x 27 ubuntu ubuntu 4096 Jan 27 13:41 ../
$ git clone https://github.com/marosg42/mate-applets.git 
Cloning into 'mate-applets'...
remote: Counting objects: 7363, done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 7363 (delta 0), reused 1 (delta 0), pack-reused 7358
Receiving objects: 100% (7363/7363), 20.95 MiB | 137.00 KiB/s, done.
Resolving deltas: 100% (4475/4475), done.
Checking out files: 100% (1090/1090), done.
$ cd mate-applets/
$ git branch 
* master
$ time git checkout multiload-network-scale 
error: Your local changes to the following files would be overwritten by checkout:
	multiload/linux-proc.c
	multiload/load-graph.c
	multiload/main.c
	multiload/org.mate.panel.applet.multiload.gschema.xml.in
	multiload/properties.c
Please commit your changes or stash them before you switch branches.
Aborting

real	0m27.345s
user	0m0.065s
sys	0m0.130s

Funny thing is, I have those files modified in the same repo, in multiload-network-scale branch but in totally different directory in that instance, they are not in remote repo. It looks like it is looking into other dirs or something like that, I cannot explain.

These are exactly the same steps done outside of mounted directory, that checkout step during clone is not happening and all works as expected.


$ rm -rf mate-applets/
$ git clone https://github.com/marosg42/mate-applets.git 
Cloning into 'mate-applets'...
remote: Counting objects: 7363, done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 7363 (delta 0), reused 1 (delta 0), pack-reused 7358
Receiving objects: 100% (7363/7363), 20.95 MiB | 130.00 KiB/s, done.
Resolving deltas: 100% (4475/4475), done.
$ cd mate-applets/
$ git branch
* master
$ time git checkout multiload-network-scale 
Branch multiload-network-scale set up to track remote branch multiload-network-scale from origin.
Switched to a new branch 'multiload-network-scale'

real	0m0.081s
user	0m0.070s
sys	0m0.012s
@townsend2010
Copy link
Contributor

The 'git checkout' issue where git says the local changes will overwrite files is now fixed. You'll still see the checkout of the files step. This step does happen in a non-mounted directory, but it is fast enough to where git doesn't report it. However, the performance on the mounted directories is really bad, so git reports the checkout progress.

@Saviq Saviq added this to the 2018.2.1 milestone Feb 21, 2018
albaguirre pushed a commit to albaguirre/multipass that referenced this issue Jun 22, 2018
Release 2018.2.1

- support JSON output in the CLI (canonical#65)
- switch to using a file socket for daemon-client IPC
- refactor ssh code and add unit tests for it
- switch to a patched libssh fork
  - improve mount performance (canonical#99)
- fix bash completion for mounts (canonical#40)
- wait for cloud-init on start (canonical#41)
- sanitize mount targets (canonical#17, canonical#47)
- support proxy configuratiion (canonical#53)
- default to a 5GB rootfs (canonical#29)
- randomize bridge subnet (canonical#49)
- fix a handful of mount bugs (canonical#71, canonical#64, canonical#78, canonical#77, canonical#83, canonical#82, canonical#81, canonical#104,
  canonical#105)
- add `--all` option to `info` (canonical#73)
- clean up networking on shutdown (canonical#75)
- set a 10s timeout for download progress (canonical#108)
- support rebooting instances (canonical#50)
- rename `connect` to `shell` to align with lxd (canonical#115)
Saviq added a commit that referenced this issue Feb 11, 2019
[hyperv] set the processor count (Fixes #77)
Saviq added a commit that referenced this issue Feb 11, 2019
#113: Release 2018.12.1-full

Based on [upstream 2018.12.1](https://github.com/CanonicalLtd/multipass/releases/tag/2018.12.1)

The summary below is for Windows and Mac only, the rest can be found in the Release Notes above.

### Highlights

- Suspend/resume on Windows, too
- Improved `shell` performance on Windows
- Now keeping instance state in sync with Hyper-V
- Improved overall responsiveness on Windows

### Bugs fixed:
- [windows] not restoring instance state on startup (#104)
- "Default Switch" name assumption is wrong (#96)
- `--cpu` ignored on Windows (#77)
- [osx] if subdirs of a mounted directory have same name as dirs in host /, incorrect uid/gid are shown in the VM (#53)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants