Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the minimum resource error improvement #2950

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

add the minimum resource error improvement #2950

wants to merge 6 commits into from

Commits on Mar 17, 2023

  1. add the minimum resource error improvement

    @georgeliao
    georgeliao committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    1210839 View commit details
    Browse the repository at this point in the history

  2. improved error message and corresponding unit tests, also corrected s… 

    …ome format
    @georgeliao
    georgeliao committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    04f7a43 View commit details
    Browse the repository at this point in the history

  3. fix a potential bug from the previous leftTrimAndReplaceLastCommaWith… 

    …And implementation and fix format
    @georgeliao
    georgeliao committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    49896dc View commit details
    Browse the repository at this point in the history

  4. Changed query_min_resource_info function to return string instead of … 

    …struct
    @georgeliao
    georgeliao committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    dc5d069 View commit details
    Browse the repository at this point in the history

  5. Addressed review comments, move the query_min_resource_info function … 

    …call into BlueprintMinimumException class.
    @georgeliao
    georgeliao committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    792bf28 View commit details
    Browse the repository at this point in the history

  6. Small variable name style change, from camel case to snake case

    @georgeliao
    georgeliao committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    683b5a3 View commit details
    Browse the repository at this point in the history